The best controller I arguably thing is the 360 controller. It just feels right to use in fighting games and fps. I like xboxs layout with the analog sticks.
Dualshock comes a close 2nd but was never a fan of the analog layout.
I find the n64 most jarring and I get that it was meant to be used differently for different games, but I still preferred the 3rd party options that took it closer to a standard gamepad.
This might be a controversial take, but this was one of my favorite controllers:
It had the size of a Duke, so comfortable to hold with my large hands, and also felt really nice when the airflow feature was turned on. It had the really bad D-Pads though.