The best controller I arguably thing is the 360 controller. It just feels right to use in fighting games and fps. I like xboxs layout with the analog sticks.
Dualshock comes a close 2nd but was never a fan of the analog layout.
I find the n64 most jarring and I get that it was meant to be used differently for different games, but I still preferred the 3rd party options that took it closer to a standard gamepad.
I really like the ps5 controller. It's comfortable, and the haptic feedback on the shoulder buttons is a really cool feature imo. The resistance is variable on the shoulder buttons so depending on what you're doing in game, it can be harder or easier to depress the button. I thought that was cool.
My issue with it is that the trigger buttons quickly got a bit mushy and loose. Didn't help to play a ton of Rocket League on it but still it's not a very durable controller.
Also, the battery was completely fucked up by the fact that I was playing it wired on PC. It was all the time charging when I was playing and then apparently discharging when the computer was off. Support is also pretty poor on PC and you often get games that are not compatible.
I'm interested in replacing it eventually by a good hall effect third party controller. Probably the Gamesir T4 Kaleid or something similar.
I'm still not 100% sold on the shoulder force feedback. Sometimes it works well, but many games do this odd thing where you hold it down and it clicks repeatedly and uncomfortably like you're breaking it and I've no idea what they're really trying to convey.