looks good to me
looks good to me
1 crossposts
looks good to me
You're viewing a single thread.
Meanwhile in another universe one of my biggest win was to introduce this line in our PR validation pipeline.
undefined
eslint . --max-warnings 0
Works so well, and soothes the warning annoyance brain, and keeps warnings from eventually becoming errors.
In a codebase with a lot of warnings is even better for me to add a disable comments for all the existing warning and then not allow any new one in.
And then each time a part of the code needs to be touched the existing warning there should be solved too.
Several times I've set the max warnings to whatever the current warning count is, and then decreased that over time.