Being direct is good. But 'too complex, refactor' as an explanation is just one word longer than 'fuck off'. You need to explain in detail why the solution is bad and which parts should be changed, in this case it just shows that the reviewer did not actually read the code.
We want to inhibit when running stuff like pacman, wget, cp or mv
There is already a separate systemd-inhibit command that does exactly what you need. Trust your users, they are capable of googling it (most of the time).
Only pacman and wget will benefit from suspend inhibition, because it will prevent breaking network connections. cp and mv will resume working just fine even when you hibernated your laptop while cp was executing. And in that case it's less bug-prone to scan your system for active TCP connections to external addresses instead of adding a hack wakelock inside your terminal or inside wget.
It is also a poor idea to mess up with system-wide settings from some command when the user does not expect it, you'll likely to get a thousand invalid bug reports that sleep mode is broken when some service randomly decides to use wget to continuously read from local Unix socket.
Good luck! I just grabbed what was lying around, and it happened to be a cookie. Next time I'll probably fry peanuts with Marmite, but that recipe is already widely known, so it's kinda less exciting.
Linux desktop on Android have been attempted many times with variable success, and it goes way beyond command line, see UserLAnd
It brings all Linux desktop apps to your phone, and all you need is Bluetooth mouse.
Do you need to edit an audio file? Try looking on Play Store, every audio editor has ads and subscription and offers only cropping and equalizer. But what if you need cross-fade? Open your Linux VM - bam! Audacity! All the audio editing tools you can ever need, and ten times more that you'll never use!
Do you need to make a meme? Go download some shitty meme maker from Play Store, that will only let you add text to ten preset images. Or get a photo editor that has twenty sepia effects but won't let you combine two images. But a simple sudo apt-get install gimp command in your Linux VM, and you get a pixel-perfect image editor with transparency support, layer support, and a thousand brushes, and you can even plug a graphics tablet into your Android tablet and have stylus pressure making brush strokes of different width, or just use an Android tablet with stylus support, the pressure works there too.
Do you want some more esoteric thing like sqlite3 database viewer? Well, Linux VM is your only choice.
It becomes even more important if you want to buy a cheap Android tablet and ise it as a kiosk for some business. Run the backend server on your Linux VM, run the frontend in the Android web browser, and you don't need to buy an expensive POS terminal.
Nope. You'll only know how good is it when you run it on the actual hardware. Yeah you can install apps on Android emulator, but what makes or breaks custom ROM is driver support on actual hardware.
Anyway, having direct unprivileged R/W access to platform memory is indeed a security hole, no matter the vendor.
It is not. ESP32 is an embedded chip with less than one megabyte of RAM. It cannot run apps or load websites with any malicious code, it only runs the firmware that you flash on it, nothing else, and of course your firmware has full access to every chip feature. If your firmware has a security hole, it's not the chip's fault.
Being direct is good. But 'too complex, refactor' as an explanation is just one word longer than 'fuck off'. You need to explain in detail why the solution is bad and which parts should be changed, in this case it just shows that the reviewer did not actually read the code.